Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Make telescope constructors & functions use binding operators #3463

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrevidela
Copy link
Collaborator

Description

Asking for opinions here. I've been using telescopes with binding operators and it's been quite helpful. So my questions are:

  • Should this go in or not?
  • Should we move all the telescopes outside of contrib and into a library or into base? If so which one?

Should this change go in the CHANGELOG?

  • If this is a fix, user-facing change, a compiler change, or a new paper
    implementation, I have updated CHANGELOG_NEXT.md (and potentially also
    CONTRIBUTORS.md).

@buzden
Copy link
Contributor

buzden commented Jan 15, 2025

Asking for opinions here

  • Should we move all the telescopes outside of contrib and into a library or into base? If so which one?

My opinion is that it should be moved outside contrib because shrinking the library with no single idea is a good thing. I think it should go to a separate library rather than to base, because I don't feel this thing needs to be in base. Maybe I feel so because I haven't used this module ever.

@gallais
Copy link
Member

gallais commented Jan 15, 2025

Should we move all the telescopes outside of contrib and into a library or into base?

I don't think we should: right telescopes indexed by a fixed size are a strict subset of right telescopes. So the library is not as general as could be.

@andrevidela
Copy link
Collaborator Author

I just realised it's not clear to me what's the objection:

  • to move it outside contrib? (And therefore it should stay in contrib)
  • to move it outside contrib and into its own library? (And therefore it should be moved into base)
  • to move it outside contrib and into base? (And therefore it should be moved somewhere else)

@gallais
Copy link
Member

gallais commented Jan 16, 2025

I'm against making it part of base because it's a corner case of a more general theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants